Conversation
JoTurk
force-pushed
the
accept-all-proto-values
branch
from
ae1c403 to
26996d7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 97.43% 97.39% -0.04%
==========================================
Files 12 12
Lines 1405 1384 -21
==========================================
- Hits 1369 1348 -21
Misses 19 19
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
force-pushed
the
accept-all-proto-values
branch
from
26996d7 to
bdca519
Compare
JoTurk
force-pushed
the
accept-all-proto-values
branch
from
bdca519 to
720504f
Compare
philipch07
approved these changes
Feb 10, 2026
| } | ||
| newMediaDesc.MediaName.Protos = append(newMediaDesc.MediaName.Protos, proto) | ||
| } | ||
| newMediaDesc.MediaName.Protos = strings.Split(field, "/") |
Contributor
There was a problem hiding this comment.
Perhaps we can leave a comment about why we made this choice or a link to this PR so people who look through the source code can find out why we would prefer to be more liberal for inputs? Although it can make sense for us internally, external users may have a harder time searching for the reasoning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes the parser accept any proto value similar to how we handle fmt.
The latest spec (rfc-8866) doesn't explicitly address unknown proto values but #242 got me thinking that this parser will break every-time a new value is added to IANA.
We can't log a warning either because we don't pass pion/logging to SDP (I think we should when we introduce a new construction API to sdp).
Also this is us being more: be liberal in what you accept from others.